[PER-10476] Extend Stela conversion in getWithChildren and record mapping#996
Open
aasandei-vsp wants to merge 1 commit into
Open
[PER-10476] Extend Stela conversion in getWithChildren and record mapping#996aasandei-vsp wants to merge 1 commit into
aasandei-vsp wants to merge 1 commit into
Conversation
aasandei-vsp
marked this pull request as draft
April 21, 2026 13:13
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #996 +/- ##
==========================================
+ Coverage 52.13% 52.14% +0.01%
==========================================
Files 354 354
Lines 12085 12095 +10
Branches 2181 2183 +2
==========================================
+ Hits 6300 6307 +7
- Misses 5555 5562 +7
+ Partials 230 226 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
aasandei-vsp
changed the title
aasandei-vsp
force-pushed
the
PER-10476-replace-navigate-lean
branch
from
July 8, 2026 13:30
b65fcfb to
bb0a021
Compare
Map archiveNumber, folderLinkId, parentFolderLinkId, the breadcrumb path arrays, and created/updated timestamps from the Stela folder response. Resolve missing folderIds through the legacy /folder/get endpoint, fetch the folder and its children in parallel, and convert failures into v1-shaped error responses so existing error handlers keep working. Hardcode accessRole to owner on both converted folders and records, since the backend removed the item-level field; without it, permission gates like the sidebar share button treated records as inaccessible. Issue: PER-10476
aasandei-vsp
force-pushed
the
PER-10476-replace-navigate-lean
branch
from
July 16, 2026 08:56
bb0a021 to
e54b14f
Compare
aasandei-vsp
changed the title
aasandei-vsp
marked this pull request as ready for review
July 16, 2026 09:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: PER-10476
Subtask: https://permanent.atlassian.net/browse/PER-10677
The tests are only to make sure we didn't make any regressions, as it does not bring any new functionality.
Manual test cases — Stela conversion in getWithChildren and record mapping
Setup: log in on an archive that has folders with images, records with metadata, and at least one unlisted share link.
EXPECTED: private/public navigation is unaffected by this PR (still uses
navigateLean) — only the flows below need testing.Unlisted share link — folder
Unlisted share link — error handling
Sidebar — record
accessRole, leaving the button permanently disabled.)Sidebar — folder
Record and folder edits (v2 endpoints)